Working on some #code written by an #intern a few years ago and it's taking all of my energy to just add the feature and not refactor the whole thing. What's the point of having an intern and not reviewing their code as they go to prevent these issues? So verbose, so much duplication
I guess I've been writing tools all by myself here with no review either, hopefully whoever takes them over eventually feels like I designed them reasonably
gör CR o snubben har skapat en (totalt onödig dessutom) variabel:
var10000
...?
det luktar chatGpt
sorry, blir decline på den
Hey, has anyone seen a good #AI #CodeReview tool? It's one of the few areas I think it could add value. Ideally something you have experience with.
I finally fixed the asynchronous block placement logic. I've attached the code. Something just doesn't feel right about his. Roast me in the comments with a code review! #codereview #gamedev #unity #csharp
Unpopular opinion on software development
Yesterday, I came across CI cultists.
They were preaching one should merge in main multiple times a day.
Quite frankly, I associate this behaviour to lab rats compulsively clicking the button to get gratifications (please don't do that to rats).
I think developers should refrain from becoming merge junkies. Code review is essential for good code quality. Automated tests suck at detecting logical errors, security vulnerabilities, and even decent code coverage.
Also, I believe pair programming is absolutely not a strategy to allow continuous integration. Everybody involved in the development process is drunk on their own bullshit reasons they made up to justify their poor design. Either the code review should be done by someone else, or the developers should sober up for a fortnight before code reviewing their own code.
PS: I am a software developer. I get drunk on my own bullshit as well.
#fediverse hivemind, I have a code review question.
I have done a massive refactor of a codebase, and I want my team to review it. Do you prefer:
a) massive pull request and iterate on it over days/weeks
b) break it down into chunks and integrate progressively
I know b) sounds intuitively like the right choice, but what do you do if you find errors in the first PR? How do you propagate that to other branches?
Review Board 7 is here! This release is all about improving your code review flow, day or night, with:
Dark Mode and Light Mode themes
Image review in the diff viewer
Microsoft Teams support
Mobile diff review
https://www.reviewboard.org/news/2024/06/06/review-board-7-its-a-bright-day-for-code-review/
Codereview feedback should only be in the form of automated tests.
If your suggested changes don't result in testable outcomes then they are a waste of time.
[2208.04259] First Come First Served: The Impact of File Position on #CodeReview
https://arxiv.org/abs/2208.04259
I just completed my first hour of *paid* code review.
It feels pretty unsettling that I need to keep track of my time and how I use it, but I’m sure I’ll get used to it.
It’s also kindda exciting that for the first time, I’ll be able to *see* where my time is actually going, and hopefully it’ll also create opportunities for optimising it.
We've been here for a while now and think it's time for an #introduction.
We are Lutra Security, an #infosec company based in Munich, Germany. Our mission, to which we have committed ourselves, is to improve IT security for our customers and in general, while maintaining the highest possible ethical and sustainability standards. We focus on providing high quality offensive security services (like #pentesting and #codereviews) and consulting, while continuously investing in research and education.
If you have any questions, please do not hesitate to contact us.
An answer in advance: Lutra Security is named after the Eurasian Otter (Lutra lutra), representing our philosophy of sustainability and the agility of our work as penetration testers.
Ok, my turn to write an #introduction full of as many hashtags as I can think of.
I am in #infosec for as long as I can remember. My main interests in the subject are #networksecurity, #websecurity, #codereview, and secure #systemdesign. Unfortunately for you (and probably for me too, I don't know at this point) I also have a Ph.D. and I am a huge fan of "The Logic of Scientific Discovery" by Karl Popper.
I also like #movies, I watch a lot of them and I make way too many references, like the one below.
While waiting for my letter from #Hogwarts, I practice my dark arts with #computerscience the only other thing close to magical spells that I know how to cast.
#introduction time!
Hello! We're Review Board, an #opensource #CodeReview / #DocReview tool from @chipx86 (me!) and others at Beanbag.
We've been around since 2006. Our product's built to work with all kinds of workflows and SCMs (from #CVS to #Git to enterprise ones like #ClearCase, #CliosoftSOS). It's extensible like a browser.
We'll cover new releases for those interested, but also talk about development in general: #Python, #webdev, SCMs, #DiffX, code review, etc.